Issue #2157 has been updated by Jeff McCune.
Adrien, you might want to check out some of the cleanup work we did.
In particular, the spec tests were doing a lot of filesystem IO which should
("must") be avoided when writing unit tests:
I think the patch in
[84bc0f8](https://github.com/puppetlabs/facter/commit/84bc0f8) does a
reasonable job of preserving your otherwise pretty good tests while avoiding
and filesystem I/O.
Thanks again for all of this. Nice to have it merged into 2.x
-Jeff
----------------------------------------
Feature #2157: External fact support
https://projects.puppetlabs.com/issues/2157#change-66968
Author: Paul Nasrat
Status: Merged - Pending Release
Priority: Normal
Assignee:
Category: interface
Target version: 2.0.0
Keywords:
Branch: https://github.com/puppetlabs/facter/pull/244
Affected Facter version:
Facter should support non-ruby facts, preferably in /etc/facter.d. It should
support these facts being either executable, in which case the result is the
value of the named fact, or in a data format such as yaml, in which case the
data file is read in and interpreted as the fact value.
It probably makes sense to initially stick to yaml for data formats, since json
doesn't ship with ruby, and to also allow executable facts to return either a
plain string or yaml.
Note that we can do this without supporting any kind of overriding, but it'd be
much better if we supported multiple (configurable?) fact directories, with a
search path. Thus, if Facter shipped with /etc/facter.d/myfactname and you
wanted to override it, you could do so by creating a new file and putting it in
a higher-priority location rather than editing a file distributed with the core.
Given we're adding structured data support, namespaced facts would be supported
with directory structures; e.g., /etc/facter.d/my/fact/name would resolve to
my::fact::name.
Ideally, the long-term direction here would be not to require any pure-ruby
facts, such that the Facter library could be rewritten in any other language
and it would function the same, because all of its actual data is outside of
ruby.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
