Issue #593 has been updated by Felix Frank. Status changed from Accepted to In Topic Branch Pending Review
Done (I assume that is what Status - In Topic Branch... does). Hadn't even realized I could do this as an outside contributor. Thanks for the pointer, Nigel! Just rebased: https://github.com/ffrank/puppet/tree/ticket/2.7.x/593-vixie-cron-headers Although now, github indicates my history is diverged from the original? Uhm. Hope I didn't make a mess. Note on tests: There are none ;) I didn't find any for the actual crontabs to begin with, so I didn't bother starting now. (Honestly, the whole issue of tests still baffles me, it's harder than tweaking the actual providers.) ---------------------------------------- Bug #593: Puppet's cron type struggles with vixie-cron https://projects.puppetlabs.com/issues/593#change-67028 Author: Peter Abrahamsen Status: In Topic Branch Pending Review Priority: Normal Assignee: Category: cron Target version: 2.7.x Affected Puppet version: 0.25.1 Keywords: cronfixit Branch: After making a few changes to my cron job in my manifest, my crontab begins to look like: <pre> # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Thu Apr 12 12:16:01 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # HEADER This file was autogenerated at Thu Apr 12 12:16:01 -0700 2007 by puppet. # HEADER While it can still be managed manually, it is definitely notrecommended. # HEADER Note particularly that the comments starting with 'Puppet Name' should # HEADER not be deleted, as doing so could cause duplicate cron jobs. # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Wed Apr 11 16:42:40 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Tue Apr 10 13:49:45 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Thu Apr 5 17:36:42 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (/tmp/crontab.XXXXWxMPKB installed on Thu Apr 5 17:08:07 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # Puppet Name: websync */10 * * * * <snip> </pre> If puppet would put its notice just before the first job it manages, I think it would avoid this problem. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
