Issue #15430 has been updated by Josh Cooper.

Category set to agent
Status changed from Unreviewed to Accepted
Target version set to 3.x

Thanks Mark. I think it can be shortened to just:

<pre>
conn = Puppet::Network::HttpPool.http_instance(url.host, url.port, false, 
(url.scheme == 'https'))
</pre>

I'm not sure why commit 
<https://github.com/puppetlabs/puppet/commit/ce44885ff63086620ec200b4e1b22b56eeec97e9>
 set a variable `ssl`, which is never used. Have you submitted pull requests 
before? It'd be great if you could verify that change and submit a pull 
request. Our process is described here 
<https://github.com/puppetlabs/puppet/blob/2.7.x/CONTRIBUTING.md>
----------------------------------------
Bug #15430: Sending HTTP reports to a non-https reporturl still tries to use SSL
https://projects.puppetlabs.com/issues/15430#change-67799

Author: Mark Johnston
Status: Accepted
Priority: Normal
Assignee: 
Category: agent
Target version: 3.x
Affected Puppet version: 3.0.0rc3
Keywords: 
Branch: 


I'm trying to submit reports via HTTP to Puppet Dashboard, which is not running 
SSL, but I'm getting the following error from the master:

Error: Report processor failed: SSL_connect returned=1 errno=0 state=SSLv2/v3 
read server hello A: unknown protocol

This is Puppet version 3.0.0rc3, from Puppet Labs' yum server 
(puppet-3.0.0-0.1rc3.2.el6-noarch), on CentOS 6.2.  My reporturl is 
"http://wpuppet:3000/reports/upload";.

I did a little poking around and it looks like in reports/http.rb, the call to 
Puppet::Network::HttpPool.http_instance() isn't correctly passing the use_ssl 
argument.  I changed the line from:

    conn = Puppet::Network::HttpPool.http_instance(url.host, url.port,
                                                   ssl=(url.scheme == 'https'))

to:


    conn = Puppet::Network::HttpPool.http_instance(url.host, url.port, 
reset=false,
                                                   use_ssl=(url.scheme == 
'https'))

and the HTTP processing now works for me.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to