Issue #11308 has been updated by Stefan Schulte.
Andrew, the refactor does not intend to remove the fact for Linux because we know how to get the operatingsystemrelease on Linux so the fact value makes sense. But the `operatingsystemrelease` fact has a fallback in case there is no special resolver for the current operatingsystem. This fallback value is to return the kernelrelease so in the end you have two facts `operatingsystemrelease` and `kernelrelease` showing the same value. If you later intend to implement a proper `operatingsystemrelease` fact for this platform (as #11082 tried for solaris) you may break existing manifests. So my point was: If we don't know how to get the `operatingsystemrelease` do not return a value at all. This way we can be sure that we do not break stuff if we later come up with a proper implementation. ---------------------------------------- Refactor #11308: general operatingsystemrelease fact should be deprecated https://projects.puppetlabs.com/issues/11308#change-67823 Author: Stefan Schulte Status: Needs Decision Priority: Normal Assignee: Category: library Target version: Keywords: Branch: Affected Facter version: If more than one `operatingsystemrelease` fact suits our system facter will try them all until one fact returns a value that is not "" or nil. There is currently one implementation of the `operatingsystemrelease` fact that suits all systems: <pre> Facter.add(:operatingsystemrelease) do setcode do Facter[:kernelrelease].value end end </pre> So if not special `operatingsystemrelease` was build for a specific OS, the one above is picked. I'd like to see this one deprecated. I don't see the point in duplicating facts (facter output is harder to read) and it gets hard if we want to implement a proper `operatingsystemrelease` fact later (#11082) because we do not know if people are already using this fact instead of using the `kernelrelease` fact directly. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
