Issue #15521 has been updated by Justin Stoller.
The code looks good functionality-wise (though style-wise I like more short blocks than long one-liners :) ). I've added that this is blocked by a closed ticket because on running the changes locally I found the forge-acceptance returns a 404 when actually trying to install from it. here's forge-dev that it's currently pointing at: <http://forge-dev.puppetlabs.com/modules?q=pmtacceptance&commit=Go> and acceptance box has the modules when searched.... <http://forge-acceptance.puppetlabs.lan/modules?q=pmtacceptance&commit=Go> but you can't browse them: <http://forge-acceptance.puppetlabs.lan/modules> Perhaps there's a distinction there about how the fixture data was loaded and it's hindering the tests? Most of these tests fail when I run them within CI: <http://slave-sles11.puppetlabs.lan:8080/view/Harness%20Testing/job/Vs%20FOSS%20Linux%20%28master%29/12/ruby=system,rvm=acceptance/#showFailuresLink> ---------------------------------------- Refactor #15521: Move puppet module acceptance tests to the new forge-acceptance host https://projects.puppetlabs.com/issues/15521#change-68486 Author: Ken Barber Status: In Topic Branch Pending Review Priority: Normal Assignee: Category: module tool Target version: 2.7.x Affected Puppet version: 2.7.18 Keywords: Branch: We seem to have a real forge-acceptance host now, and it would be great if we can start to point to it, so we can free up forge-dev for our own purposes. Currently the forge acceptance tests require multiple points of change, optimally if we can reduce this to 1 point of change that would be great - ideally if we can make it configurable enough to point to our own host of choice when required this would be even better. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
