Issue #15899 has been updated by Andrew Parker. Status changed from Unreviewed to Rejected Assignee deleted (eric sorenson)
Although I agree that the `indirection` is ugly and not ideal, this patch has no other redeeming value than aesthetics. It will cause another point of friction between 2.7 and 3.0 (as pointed out in the pull request that occurred between 2.6 and 2.7) and will either cause another point of deprecated code or a break for any custom termini or other plugins that went through the indirectors. We will fix the related bug #15193 in the current situation rather than creating a larger break. ---------------------------------------- Bug #15899: Class methods should be added back to indirected classes https://projects.puppetlabs.com/issues/15899#change-68732 Author: Luke Kanies Status: Rejected Priority: Normal Assignee: Category: API Target version: 3.0.0 Affected Puppet version: Keywords: Branch: https://github.com/puppetlabs/puppet/pull/243 I've no idea how this happened, because I was sure Daniel had fixed this already. You used to be able to call 'find', 'search', and 'destroy' directly on any indirected class, and 'save' on any instance of an indirected class. This was removed for no real reason a long time ago, and it should be added back. This would allow actions like: `catalog = Puppet::Resource::Catalog.find "hostname" catalog.save` Otherwise you have to do: `catalog = Puppet::Resource::Catalog.indirection.find "hostname" catalog.class.indirection.save` Yuck. If this were fixed, then I'm pretty sure the related static compiler bug will just go away. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
