Issue #15945 has been updated by eric sorenson.

Status changed from Unreviewed to Code Insufficient

We should make sure a proper fix for #8040 would fix this as well.
----------------------------------------
Bug #15945: Tags still travel by old 0.25.x containment rules instead of post 
2.6 containment rules
https://projects.puppetlabs.com/issues/15945#change-69274

Author: Nick Fagerlund
Status: Code Insufficient
Priority: Normal
Assignee: 
Category: compiler
Target version: 
Affected Puppet version: 2.7.12
Keywords: 
Branch: 


Okay, you know #8040, the anchor pattern issue with class-to-class containment? 
Tags still obey the old containment behavior.

    # tags-multiple.pp
    class one {
        notify {"the one in class one":}
        include three
    }
    class two {
        notify {"the one in class two":}
        include three
    }
    class three {
        notify{"the one in class three":}
    }
    
    include one
    include two

    $ puppet master --compile screech.magpie.lan --manifest tags-multiple.pp > 
tagoutput2.json

If tags obeyed the post-2.6 rule of "classes can't contain classes," then we'd 
expect the Notify in class three to ONLY have the tag "three." Instead, it will 
have "three" and EITHER the tag "one" or "two," depending on parse-order. 

This demonstrates that tagging obeys the old containment behavior (a class will 
be contained by the FIRST class that declares it).

The behavior itself seems like not a big deal at all, but the discrepancy 
suggests something whacky about the way containment is implemented, and might 
indicate a deeper problem.

Also, since tags are so fluffy anyway, perhaps it makes sense for them to have 
their own completely independent rule. (Like, EVERY class that declares a class 
will pass on its tags.) 


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to