Issue #16027 has been updated by eric sorenson.

Status changed from Unreviewed to Accepted
Target version set to 3.0.0

I had to repro with `puppet apply --trace /some/test/file.pp`

But between 2.7.x and 3.x indeed loses method info

<pre>
[[email protected] ~/Sandbox/puppet/lib/puppet/parser]% puppet apply --trace 
~/Sandbox/array-15628.pp                   
Class[main]{}
/Users/eric/Sandbox/puppet/lib/puppet/parser/resource.rb:116:in `finish'
/Users/eric/Sandbox/puppet/lib/puppet/parser/resource.rb:84:in `evaluate'
/Users/eric/Sandbox/puppet/lib/puppet/parser/compiler.rb:287:in `evaluate_main'
</pre>

on upstream/2.7.x vs upstream/3.x

</pre>
[[email protected] ~/Sandbox/puppet/lib/puppet/parser]% vi resource.rb 
[[email protected] ~/Sandbox/puppet/lib/puppet/parser]% puppet apply --trace 
~/Sandbox/array-15628.pp
Class[main]{}
Error: Testing on node glitch.local
/Users/eric/Sandbox/puppet/lib/puppet/parser/resource.rb:111
/Users/eric/Sandbox/puppet/lib/puppet/parser/resource.rb:80
/Users/eric/Sandbox/puppet/lib/puppet/parser/compiler.rb:282
</pre>

I notice the 3.x output is also in color. There's definitely been some changes 
to the stack trace work, and I agree it's a regression.
----------------------------------------
Bug #16027: Stack traces are printed without method names
https://projects.puppetlabs.com/issues/16027#change-69590

Author: Luke Kanies
Status: Accepted
Priority: Normal
Assignee: 
Category: 
Target version: 3.0.0
Affected Puppet version: 3.0.0rc3
Keywords: 
Branch: 


When I get an exception that produces a stack trace, I'm still getting file 
names and line numbers, but no method names.  E.g., here's one I caused:
    Error: Testing on node localhost
    /Users/luke/git/puppet/lib/puppet/parser/resource.rb:111
    /Users/luke/git/puppet/lib/puppet/parser/resource.rb:80
    /Users/luke/git/puppet/lib/puppet/parser/compiler.rb:282
    /Users/luke/git/puppet/lib/puppet/parser/compiler.rb:96
    /Users/luke/git/puppet/lib/puppet/parser/compiler.rb:29
    /Users/luke/git/puppet/lib/puppet/indirector/catalog/compiler.rb:77
    /Users/luke/git/puppet/lib/puppet/util.rb:184
    /Users/luke/git/puppet/lib/puppet/indirector/catalog/compiler.rb:75
    /Users/luke/git/puppet/lib/puppet/indirector/catalog/compiler.rb:35
    /Users/luke/git/puppet/lib/puppet/indirector/indirection.rb:191
    /Users/luke/git/puppet/lib/puppet/application/apply.rb:204
    /Users/luke/git/puppet/lib/puppet/application/apply.rb:146
    /Users/luke/git/puppet/lib/puppet/application.rb:342
    /Users/luke/git/puppet/lib/puppet/application.rb:436
    /Users/luke/git/puppet/lib/puppet/application.rb:342
    /Users/luke/git/puppet/lib/puppet/util.rb:513
    /Users/luke/git/puppet/lib/puppet/application.rb:342
    /Users/luke/git/puppet/lib/puppet/util/command_line.rb:74
    /Users/luke/git/puppet/bin/puppet:10
    Error: Testing on node localhost
    /Users/luke/git/puppet/lib/puppet/parser/resource.rb:111
    /Users/luke/git/puppet/lib/puppet/parser/resource.rb:80
    /Users/luke/git/puppet/lib/puppet/parser/compiler.rb:282
    /Users/luke/git/puppet/lib/puppet/parser/compiler.rb:96
    /Users/luke/git/puppet/lib/puppet/parser/compiler.rb:29
    /Users/luke/git/puppet/lib/puppet/indirector/catalog/compiler.rb:77
    /Users/luke/git/puppet/lib/puppet/util.rb:184
    /Users/luke/git/puppet/lib/puppet/indirector/catalog/compiler.rb:75
    /Users/luke/git/puppet/lib/puppet/indirector/catalog/compiler.rb:35
    /Users/luke/git/puppet/lib/puppet/indirector/indirection.rb:191
    /Users/luke/git/puppet/lib/puppet/application/apply.rb:204
    /Users/luke/git/puppet/lib/puppet/application/apply.rb:146
    /Users/luke/git/puppet/lib/puppet/application.rb:342
    /Users/luke/git/puppet/lib/puppet/application.rb:436
    /Users/luke/git/puppet/lib/puppet/application.rb:342
    /Users/luke/git/puppet/lib/puppet/util.rb:513
    /Users/luke/git/puppet/lib/puppet/application.rb:342
    /Users/luke/git/puppet/lib/puppet/util/command_line.rb:74
    /Users/luke/git/puppet/bin/puppet:10
     

Note that I'm actually getting it twice.

I caused the stacktrace with this patch:

    diff --git a/lib/puppet/parser/resource.rb b/lib/puppet/parser/resource.rb
    index 6d9f996..5bfc37f 100644
    --- a/lib/puppet/parser/resource.rb
    +++ b/lib/puppet/parser/resource.rb
    @@ -107,6 +107,8 @@ class Puppet::Parser::Resource < Puppet::Resource
    add_defaults
    add_scope_tags
    validate
    +    p self
    +    raise "Testing"
    end
    # Has this resource already been finished?
    

And running 'puppet apply ~/bin/test.pp'.

This is against current HEAD of 3.x.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to