Issue #16139 has been updated by Chris Price. Branch set to https://github.com/puppetlabs/puppet/pull/1073
Updated ticket with URL of pull request. ---------------------------------------- Refactor #16139: Inconsistent access @puppet_version and @report_format from a report processor https://projects.puppetlabs.com/issues/16139#change-69932 Author: Chris Price Status: Unreviewed Priority: Normal Assignee: Category: Target version: 3.x Affected Puppet version: Keywords: Branch: https://github.com/puppetlabs/puppet/pull/1073 Most of the fields that are needed by a report processor (at least, in order to implement a report processor that leverages the same set of data that our built-in "store" report processor uses) have accessor methods available for them (or are directly exposed via attr_reader or attr_accessor--which, to the consumer, are indistinguishable from any other type of accessor method). However, there are a couple of important ones that are only accessible by reading the instance variables directly. They are (at least): * @puppet_version * @report_format These should be exposed via accessors as well, both for consistency and to abstract the implementation details away from the consumer. I'm using the instance variables directly in the puppetdb report processor for now, but would like to switch to accessors at some point in the future. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
