Issue #15959 has been updated by Daniel Pittman.

Status changed from In Topic Branch Pending Review to Tests Insufficient
Target version changed from 3.x to 2.7.x

This should target 2.7.x - it is clearly a bug fix that applies to the stable 
release.

Unfortunately, the test changes also fail on the Mac:

<pre>
  1) Puppet::Type::User::ProviderUseradd#create should set password age rules
     Failure/Error: provider.expects(:execute).with(['/usr/bin/chage', '-m', 5, 
'-M', 10, 'myuser'])
     Mocha::ExpectationError:
       not all expectations were satisfied
       unsatisfied expectations:
       - expected exactly once, not yet invoked: 
#<Puppet::Type::User::ProviderUseradd:0x10af7d310>.execute(['/usr/bin/chage', 
'-m', 5, '-M', 10, 'myuser'])
       satisfied expectations:
       - allowed any number of times, not yet invoked: 
Signal.trap(any_parameters)
       - allowed any number of times, not yet invoked: 
Puppet::Type::User::ProviderUseradd.command(:delete)
       - allowed any number of times, not yet invoked: 
Puppet::Type::User::ProviderUseradd.command(:modify)
       - allowed any number of times, invoked once: 
Puppet::Type::User::ProviderUseradd.command(:add)
       - allowed any number of times, not yet invoked: 
Puppet::Type::User::ProviderUseradd.command(:password)
       - expected exactly once, invoked once: 
#<Puppet::Type::User::ProviderUseradd:0x10af7d310>.execute(['/usr/sbin/useradd',
 'myuser'])
     # ./spec/unit/provider/user/useradd_spec.rb:54

  2) Puppet::Type::User::ProviderUseradd#check_manage_home should return an 
array with -m flag if home is managed
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:117

  3) Puppet::Type::User::ProviderUseradd#check_manage_home should return an 
array with -r flag if home is managed
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:122

  4) Puppet::Type::User::ProviderUseradd#addcmd should call command with :add
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  5) Puppet::Type::User::ProviderUseradd#addcmd should add properties
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  6) Puppet::Type::User::ProviderUseradd#addcmd should check and add if dup 
allowed
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  7) Puppet::Type::User::ProviderUseradd#addcmd should check and add if home is 
managed
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  8) Puppet::Type::User::ProviderUseradd#addcmd should add the resource :name
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  9) Puppet::Type::User::ProviderUseradd#addcmd should return an array with 
full command
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  10) Puppet::Type::User::ProviderUseradd#addcmd should return an array without 
-e if expiry is undefined full command
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  11) Puppet::Type::User::ProviderUseradd#addcmd on systems featuring 
system_users should return an array with -r if system? is true
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  12) Puppet::Type::User::ProviderUseradd#addcmd on systems featuring 
system_users should return an array without -r if system? is false
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:150

  13) Puppet::Type::User::ProviderUseradd#passcmd should call command with :pass
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:217

  14) Puppet::Type::User::ProviderUseradd#passcmd should return nil if neither 
min nor max is set
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:217

  15) Puppet::Type::User::ProviderUseradd#passcmd should return a chage command 
array with -m <value> and the user name if password_min_age is set
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:217

  16) Puppet::Type::User::ProviderUseradd#passcmd should return a chage command 
array with -M <value> if password_max_age is set
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:217

  17) Puppet::Type::User::ProviderUseradd#passcmd should return a chage command 
array with -M <value> -m <value> if both password_min_age and password_max_age 
are set
     Failure/Error: resource[:managehome] = :true
     Puppet::Error:
       Parameter managehome failed: User provider directoryservice can not 
manage home directories
     # ./lib/puppet/parameter.rb:165:in `fail'
     # ./lib/puppet/parameter.rb:251:in `validate'
     # ./lib/puppet/parameter.rb:271:in `value='
     # ./lib/puppet/type.rb:449:in `[]='
     # ./spec/unit/provider/user/useradd_spec.rb:217
</pre>

If you can't figure out fixing those shortly I will take a look, but it will be 
at least a week before I have time for that. :(
----------------------------------------
Bug #15959: solaris: groupadd system parameter is not supported on solaris
https://projects.puppetlabs.com/issues/15959#change-70301

Author: Rahul Gopinath
Status: Tests Insufficient
Priority: Normal
Assignee: Stefan Schulte
Category: group
Target version: 2.7.x
Affected Puppet version: 
Keywords: 
Branch: https://github.com/puppetlabs/puppet/pull/1052


    | sudo puppet resource group zoro ensure=present system=true

Error: Could not create group zoro: Execution of '/usr/sbin/groupadd -r zoro' 
returned 2: /usr/sbin/groupadd: illegal option -- r
UX: groupadd: ERROR: invalid syntax.
usage: groupadd [-g gid [-o]] group

Error: /Group[zoro]/ensure: change from absent to present failed: Could not 
create group zoro: Execution of '/usr/sbin/groupadd -r zoro' returned 2: 
/usr/sbin/groupadd: illegal option -- r
UX: groupadd: ERROR: invalid syntax.
usage: groupadd [-g gid [-o]] group

group { 'zoro':
  ensure => 'absent',
}



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to