Issue #2888 has been updated by Jeff McCune.
Thanks to Josh figuring out that the Settings catalog is causing a managed file resource to create the `puppetdlock` file as an empty file. The resource gets added to the settings catalog here: <https://github.com/puppetlabs/puppet/blob/2.7.x/lib/puppet/util/settings.rb#L558> We can pry open the runtime and look around with something like this: <pre> diff --git a/lib/puppet/util/settings.rb b/lib/puppet/util/settings.rb index b0614e5..9695c51 100644 --- a/lib/puppet/util/settings.rb +++ b/lib/puppet/util/settings.rb @@ -553,13 +553,23 @@ class Puppet::Util::Settings @config.values.find_all { |value| value.is_a?(FileSetting) }.each do |file| next unless (sections.nil? or sections.include?(file.section)) next unless resource = file.to_resource + # XXX We _could_ special-case the puppetdlock file at this point. This + # seems like a bad idea. Better, I think to enable FileSetting instances + # to opt out of the Settings catalog and honor that preference. next if catalog.resource(resource.ref) + # XXX This appears to be where the puppetdlock file gets added to the + # catalog. The catalog creates a zero byte file when it manages the file + # resource. + binding.pry if resource.to_s =~ /puppetdlock/ catalog.add_resource(resource) end add_user_resources(catalog, sections) + # XXX We could take this opportunity to wrap the catalog.apply method. + # This would allow us to figure out exactly when the Settings catalog gets + # applied. catalog end -- </pre> ---------------------------------------- Bug #2888: puppetd doesn't always cleanup lockfile properly https://projects.puppetlabs.com/issues/2888#change-71166 Author: Peter Meier Status: Accepted Priority: Normal Assignee: Jeff McCune Category: plumbing Target version: 3.0.0 Affected Puppet version: 0.25.1 Keywords: Branch: ok I had the patch #2661 now running for some weeks and I had nearly no problems anymore. However from time to time (maybe once,twice a week) a random client doesn't remove its lockfile (@/var/lib/puppet/state/puppetdlock@), hence future runs fail. I assume this might still happen due to a uncatched exception (as in #2261), however the problem is a) hard or nearly impossible to reproduce and b) it occurs really by random. The only thing I can see in the logs: <pre> Nov 30 19:27:41 foobar puppetd[26228]: Finished catalog run in 98.79 seconds Nov 30 20:00:02 foobar puppetd[3000]: Could not retrieve catalog from remote server: Error 502 on SERVER: <html>^M <head><title>502 Bad Gateway</title></head>^M <body bgcolor="white">^M <center><h1>502 Bad Gateway</h1></center>^M <hr><center>nginx/0.6.39</center>^M </body>^M </html>^M Nov 30 20:00:03 foobar puppetd[3000]: Using cached catalog Nov 30 20:00:03 foobar puppetd[3000]: Could not retrieve catalog; skipping run Nov 30 20:00:04 foobar puppetd[12169]: Run of Puppet configuration client already in progress; skipping Nov 30 20:30:04 foobar puppetd[21230]: Run of Puppet configuration client already in progress; skipping </pre> as I run puppetd by cron twice an hour with --splay I assume that the run between 19:30 and 20:00 got delayed till 20:00. At this time (20:00) a puppetmaster restart happens and due to that the 502 occured. This was the run of pid 3000, the next run (pid 12169) failed, this could either be as pid 3000 was still running or because there was already no puppetd anymore running and the lock file haven't been removed. However every future run failed as well as the lockfile wasn't removed. So somehow puppet doesn't remove lockfiles properly under certain conditions. PS: If you think it's better to reopen the old bugreport, close this one and duplicate and re-open #2261 -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
