Issue #1856 has been updated by Mikael Fridh.
Now you've got an initscript which will kill any other process willy-nilly if you imagine the following scenario (which just happened to me!!!) - Scenario: * Puppet agent has shut down uncleanly * PID file is kept around with pid 5555 * Another process reuses pid 5555 * <moments pass> * yum install puppet happens (maybe from inside a fresh puppet agent run that's supposed to repair everything) * Boom, %postun runs a condrestart which will kill pid 5555 even if it's NOT the "puppetd" process. I'm not sure who to blame here but passing -p to killproc makes it in essence "reckless" ... ---------------------------------------- Bug #1856: redhat init script doesn't honor pidfile on shutdown/reload https://projects.puppetlabs.com/issues/1856#change-71608 Author: Marc Fournier Status: Closed Priority: Normal Assignee: Todd Zullinger Category: Red Hat Target version: Affected Puppet version: 0.24.7 Keywords: redhat init script shutdown cron Branch: When puppet is run "by hand" and something happens to run "service puppet stop" at the same time, puppet get's killed because the initscript calls "pidof puppet" instead of checking if a pidfile exists. This is an problem when puppet is configured to be run by cron and is instructed to ensure no puppet service is running. Puppet sort of kills himself halfway through the job. Attached is a patch which solves the issue. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
