Issue #16395 has been updated by eric sorenson. Status changed from Unreviewed to Investigating Assignee set to Ryan Coleman
Bumping to Ryan for PMT-related triage. ---------------------------------------- Bug #16395: puppetlabs_spec_helper does not exclude fixture symlinks when building the module https://projects.puppetlabs.com/issues/16395#change-72727 Author: Björn Albers Status: Investigating Priority: Normal Assignee: Ryan Coleman Category: Target version: Affected Puppet version: 2.7.19 Keywords: puppetlabs_spec_helper Branch: ...which causes some funky behaviour when installing the module via PMT: On my production system I see an error during module installation, obviously due to the included symlink (which points to nirvana on that system): # puppet module install bjoernalbers-dcm4chee Preparing to install into /etc/puppet/modules ... Downloading from http://forge.puppetlabs.com ... Installing -- do not interrupt ... Error: No such file or directory - /etc/puppet/modules/dcm4chee/spec/fixtures/modules/dcm4chee Error: Try 'puppet help module install' for usage # ls -l /etc/puppet/modules/dcm4chee/spec/fixtures/modules/dcm4chee lrwxrwxrwx 1 root root 38 Sep 13 19:30 /etc/puppet/modules/dcm4chee/spec/fixtures/modules/dcm4chee -> /Users/bjoern/code/rgp/puppet-dcm4chee On my dev. system you can see, that the symlink is included (or not, if i remove it first): $ sw_vers ProductName: Mac OS X ProductVersion: 10.7.4 BuildVersion: 11E53 $ ruby --version ruby 1.8.7 (2011-12-28 patchlevel 357) [universal-darwin11.0] $ bundle show puppetlabs_spec_helper /Users/bjoern/code/rgp/puppet-dcm4chee/vendor/ruby/1.8/gems/puppetlabs_spec_help er-0.3.0 $ find . -type l ./pkg/bjoernalbers-dcm4chee-0.0.1/spec/fixtures/modules/dcm4chee ./spec/fixtures/modules/dcm4chee $ ls -l spec/fixtures/modules/dcm4chee lrwxr-xr-x 1 bjoern staff 38 13 Sep 19:30 spec/fixtures/modules/dcm4chee -> / Users/bjoern/code/rgp/puppet-dcm4chee $ rm spec/fixtures/modules/dcm4chee $ vim Modulefile $ bin/rake build $ find . -type l ./pkg/bjoernalbers-dcm4chee-0.0.1/spec/fixtures/modules/dcm4chee $ ls -l pkg total 22272 drwxr-xr-x 15 bjoern staff 510 13 Sep 17:50 bjoernalbers-dcm4chee-0.0.1 -rw-r--r-- 1 bjoern staff 5699031 13 Sep 17:50 bjoernalbers-dcm4chee-0.0.1.tar.gz drwxr-xr-x 15 bjoern staff 510 13 Sep 19:44 bjoernalbers-dcm4chee-0.0.2 -rw-r--r-- 1 bjoern staff 5698853 13 Sep 19:44 bjoernalbers-dcm4chee-0.0.2.tar.gz -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
