Issue #16698 has been updated by Andrew  Parker.

After reviewing with Josh Cooper, we came to the decision that not setting the 
`Puppet::Node` `cache_terminus` is safe and will resolve this. However we 
decided to leave the code for the store configs (and active record) node 
implementation even though puppet will use it. This is because we felt that 
although puppet may not use it, there is a possibility that it is being used by 
other systems that have used puppet as a library.  We also made the decision to 
not deprecate the store configs implementation of `Puppet::Node` since it keeps 
it consistent that with all of the other things that have store configs.

Not deprecating the store configs for nodes may turn out to be the wrong 
decision, but only time will tell.
----------------------------------------
Bug #16698: external node classifier script is not being called when 
storedconfigs is on
https://projects.puppetlabs.com/issues/16698#change-73245

Author: Chris Mague
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Andrew  Parker
Category: 
Target version: 3.0.1
Affected Puppet version: 3.0.0
Keywords: 
Branch: https://github.com/puppetlabs/puppet/pull/1220


    $ ruby -v
    ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]

    $ puppet --version
    3.0.0 (installed via gem)

#puppet.conf

    [master]
    node_terminus  = exec
    external_nodes = /usr/share/puppet-dashboard/bin/external_node
    
in puppet-3.0.0/lib/puppet/indirector.rb added the following lines:

    38 Puppet.warning "DTM: making sure in indirector #{ 
Puppet[:external_nodes] } is called"
    39 Puppet.warning "DTM: making sure in indirector #{ Puppet[:node_terminus] 
} trying termnius is called"
    
These show up in the puppet logs that the values are correctly established

    Oct  2 18:50:19 puppet puppet-master[16541]: DTM: making sure in indirector 
/usr/share/puppet-dashboard/bin/external_node is called
    Oct  2 18:50:19 puppet puppet-master[16541]: DTM: making sure in indirector 
exec trying termnius is called
    
in puppet-3.0.0/lib/puppet/indirector/node/exec.rb

   12     Puppet.warning "DTM: making sure #{ Puppet[:external_nodes] } is 
called"

That message is not showing up in the logs and the external node classifier 
script is not getting called.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to