Issue #13334 has been updated by Andrew Parker. Status changed from Accepted to Closed
This was done as part of the work for #16189. ---------------------------------------- Refactor #13334: Improve handling of "run_mode" setting https://projects.puppetlabs.com/issues/13334#change-73287 Author: Chris Price Status: Closed Priority: Normal Assignee: Category: settings Target version: Waldorf Affected Puppet version: Keywords: Branch: I made a fair number of changes to how we work with (and tiptoe around) the "run_mode" setting as part of #7749 and related tickets ( https://github.com/puppetlabs/puppet/pull/571 ). We have quite a few places in the code that branch based on the value of this setting, and these spots seem a bit fragile. I think it would be worth spending some time figuring out if there are ways we could clean this up. If nothing else, I believe that "run_mode" should not be treated as a "normal" setting in the puppet Settings class; it should be pulled out of the defaults.rb settings definitions, and handled in some more specialized and explicit fashion (such as becoming a first-class attribute of the Settings class). I've left some comments in the code (settings.rb, defaults.rb, a few other places) that discuss this. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
