Issue #8210 has been updated by Jeff McCune.
Andreas Zuber wrote: > I wrote another fact that checks if virt-what is installed and uses it's > output to determine the virtual machine type. The has_weight = 200 makes sure > this fact is ran first. Don't know if this is a good way to do it. Ideas, > suggestions, rants? > > https://github.com/ZeroPointEnergy/facter/commit/db59e104507a3db4c7a5578c975bb2f8939b146c Andreas, This fact looks really good. I'd like to merge it into Facter core once I add some tests around it. Would you mind signing the [contributor license agreement](https://projects.puppetlabs.com/contributor_licenses/sign) so I can take your patch as-is? Thanks, -Jeff ---------------------------------------- Bug #8210: virtual fact should work for EL kvm guests https://projects.puppetlabs.com/issues/8210#change-74092 Author: Markus Falb Status: Accepted Priority: Normal Assignee: Jeff McCune Category: library Target version: 1.6.x Keywords: Branch: Affected Facter version: 1.6.2 The Output from /proc/cpuinfo can not used reliable for telling that it is a kvm virtual machine. On a CentOS 5.6 kvm Host with CentOS guests /proc/cpuinfo tells me: for a smp guest model name : QEMU Virtual CPU version 0.9.1 with only one cpu in the guest: model name : Pentium II (Klamath) but in both cases: $ dmidecode -t 4 ... Manufacturer: QEMU ... I believe it is possible to specify what cpu is used so on the commandline, so relying on the model name is not always working For more information please also have a look at <br>[https://bugzilla.redhat.com/show_bug.cgi?id=707523](https://bugzilla.redhat.com/show_bug.cgi?id=707523) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
