Issue #16611 has been updated by eric sorenson. Status changed from Unreviewed to Investigating Assignee set to Moses Mendoza
Moses can you check this out? `git annotate ext/debian/puppetmaster-passenger.postinst` pointed the finger at you... ---------------------------------------- Bug #16611: puppetmaster-passenger apt package should not automatically configure a virtualhost https://projects.puppetlabs.com/issues/16611#change-74729 Author: Patrick Hemmer Status: Investigating Priority: High Assignee: Moses Mendoza Category: passenger Target version: Affected Puppet version: 2.7.19 Keywords: puppetmaster passenger apt package ubuntu virtualhost Branch: The [puppetmaster-passenger package](http://apt.puppetlabs.com/pool/precise/main/p/puppet/puppetmaster-passenger_2.7.19-1puppetlabs2_all.deb) tries to run a post-install script to set up a virtualhost configuration. The way this is being done is not compatible with installing the package via puppet. 1. If puppet is providing a custom virtualhost (from a template) it may be installed to a different location in which case the 2 virtualhosts will now conflict. 2. The post install script uses `puppet master --configprint cacrl` for the `SSLCARevocationFile` parameter. This is incorrect as the `cacrl` attribute is only present if puppet is acting as a CA server. The correct config parameter is `hostcrl`. This will also cause apache to fail when the file is missing. 3. The post-install script does a full restart of apache2 instead of a reload which can cause interruptions if other virtualhosts are being used. Especially if the restart fails due to one of the above 2 issues. In order for puppet to install puppetmaster-passenger, it has to first install apache, create /etc/apache2/sites-enabled/puppetmaster as a blank file so the package install doesn't create it, and then install puppetmaster-passenger. This is just ugly. I think it would be fine if the post-install were to create the config in sites-available, but **it should not enable the config or bounce apache**. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
