Issue #16635 has been updated by Clay Caviness. Assignee changed from Clay Caviness to eric sorenson
Not sure what the proper etiquette here is with "needs more information" and assigned to reporter; I've replied and assigned it to Eric, who asked for the information. Let me know if that's not proper. ---------------------------------------- Bug #16635: pkgdmg provider doesn't honor http_proxy_host/http_proxy_port https://projects.puppetlabs.com/issues/16635#change-74975 Author: Clay Caviness Status: Needs More Information Priority: Normal Assignee: eric sorenson Category: OSX Target version: Affected Puppet version: Keywords: Branch: The pkgdmg provider doesn't honor http_proxy_host/http_proxy_port settings. The actual file is downloaded using an exec to curl, no proxy information is passed: <pre>curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source</pre> I copied `http_proxy_env`, `http_proxy_host`, and `http_proxy_port` functions from `puppet/forge/repository.rb` and added them to `pkgdmg.rb`, and tweaked the call to curl in `pkgdmg.rb`: <pre>if http_proxy_host and not http_proxy_port curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source, "--proxy", http_proxy_host elsif http_proxy_host and http_proxy_port curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source, "--proxy", "#{http_proxy_host}:#{http_proxy_port}" else curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source end </pre> I attached my patched pkgdmg.rb. I don't really understand how the `commands :curl => "/usr/bin/curl"` and `curl 'foo', 'bar', 'baz'` stuff actually works, so there's probably a much smoother way to do this... -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
