Issue #11308 has been updated by Stefan Schulte.

Another fact where I do not like the defaultvalue is the `osfamily` fact. The 
default value is to return the `kernel` fact which in my opinion makes no 
sense. If we want to introduce a new osfamily fact we automatically have a 
change in behaviour (say we want to define a new `osfamily` for ArchLinux the 
fact value will change from `Linux` to `ArchLinux`). So I am strongly for not 
setting a fact at all if we do not have a natural default and don't just use 
the value of another facts as defaults.
----------------------------------------
Refactor #11308: general operatingsystemrelease fact should be deprecated
https://projects.puppetlabs.com/issues/11308#change-75130

Author: Stefan Schulte
Status: Needs Decision
Priority: Normal
Assignee: 
Category: library
Target version: 
Keywords: 
Branch: 
Affected Facter version: 


If more than one `operatingsystemrelease` fact suits our system facter will try 
them all until one fact returns a value that is not "" or nil.

There is currently one implementation of the `operatingsystemrelease` fact that 
suits all systems:
<pre>
Facter.add(:operatingsystemrelease) do
  setcode do Facter[:kernelrelease].value end
end
</pre>

So if not special `operatingsystemrelease` was build for a specific OS, the one 
above is picked.

I'd like to see this one deprecated. I don't see the point in duplicating facts 
(facter output is harder to read) and it gets hard if we want to implement a 
proper `operatingsystemrelease` fact later (#11082) because we do not know if 
people are already using this fact instead of using the `kernelrelease` fact 
directly. 


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to