Issue #16511 has been updated by Jeff McCune.

Status changed from Accepted to In Topic Branch Pending Review
Branch set to https://github.com/puppetlabs/facter/pull/347

# Pull request

I'm going to fix this bug, then make another pass at cleaning up the EC2 fact 
so this is much easier to patch and work with in the future.

I pulled an example `arp -a` command for Solaris 8 from some online 
documentation.

<https://github.com/puppetlabs/facter/pull/347>
----------------------------------------
Bug #16511: EC2 code breaks facter on Solaris 8 and earlier
https://projects.puppetlabs.com/issues/16511#change-75220

Author: Alex Harvey
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Jeff McCune
Category: solaris
Target version: 1.6.x
Keywords: solaris
Branch: https://github.com/puppetlabs/facter/pull/347
Affected Facter version: 


The following code in lib/facter/util/ec2.rb breaks various facts on versions 
of Unix that do not support the arp -n option.

    # Test if the host has an arp entry in its cache that matches the EC2 arp,
    # which is normally +fe:ff:ff:ff:ff:ff+.
    def has_ec2_arp?
      mac_address = "fe:ff:ff:ff:ff:ff"
      if Facter.value(:kernel) == 'windows'
        arp_command = "arp -a"
        mac_address.gsub!(":","-")
      else
        arp_command = "arp -an"
      end

This results in failures like the following -

    $ facter swapsize
    arp: -an: unknown host
    2.00 GB



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to