Issue #11612 has been updated by Alex Harvey.
I have had a look at lib/facter/util/ip.rb and have confirmed both the
existence of the bug that Hongbo Hu sought to fix and the validity of his fix.
I made a minor variation to his code -
<pre>
def self.get_all_interface_output
case Facter.value(:kernel)
...
when 'HP-UX'
output = %x{/bin/netstat -in | sed -e 1d -e 's/*//g'}
...
</pre>
- because it involves one less external call to 'sed'.
After looking at the RSpec tests, however, it is the entire output of the
method 'get_all_interface_output' that gets stubbed and the sed command is only
an input to that function. It seems to me the most sensible thing to do here
is not to bother with new tests here.
----------------------------------------
Bug #11612: add facter support for ia 11.31 hpux processor discover and a bug
fix for network interface
https://projects.puppetlabs.com/issues/11612#change-75344
Author: hongbo hu
Status: In Topic Branch Pending Review
Priority: Normal
Assignee: Jeff McCune
Category: library
Target version: 1.6.15
Keywords: facter hpux
Branch: https://github.com/puppetlabs/facter/pull/232
Affected Facter version:
1. add cpu information support to facter support HPUX 11.31 IA64
2. when server has mc-sg the network card has standby lan card marked
with '*' ,when run faster ,it'll show ifconfig no such interface error
pull requre at github
https://github.com/puppetlabs/facter/pull/127
I'll add more feature for hp and aix
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
