Issue #17319 has been updated by Andrew  Parker.

Tracker changed from Bug to Feature
Status changed from Unreviewed to Needs Decision
Assignee set to eric sorenson
Target version deleted (2.7.20)

This is a request for a new feature, and after a bit of discussion with Nan and 
Josh Cooper, this isn't a regression of functionality in 2.7. I'm removing the 
target of 2.7.20 and sending this over to Eric for a decision about this.
----------------------------------------
Feature #17319: show_diff should honor loglevel
https://projects.puppetlabs.com/issues/17319#change-75533

Author: Jo Rhett
Status: Needs Decision
Priority: Normal
Assignee: eric sorenson
Category: reports
Target version: 
Affected Puppet version: 2.7.19
Keywords: 
Branch: 


Right now the show_diff is shown every time the file is modified, no matter 
what loglevel the file changes are set for. This defeats the entire purpose of 
loglevel.

<pre>
On Tue, Mar 8, 2011 at 4:46 PM, Mohamed Lrhazi <[email protected]> wrote:
> I have resource for which I set this to debug, like so:
>
> file { "/tmp/foo":
>  content => inline_template("..."),
>  loglevel => debug,
> }
>
> I was expecting the following command to not log anything about it,
> but it does, it logs the diff of the file.. Why?

If you don't want to see the diff output when the file changes, turn
off the show_diff option.

Thanks,

Nan</pre>

Sure, Nan. Perhaps if we don't want to see every resource changed, we should 
turn off reporting altogether? Is this not exactly the purpose for loglevel?

Especially given that the diff is included with the resource report which is 
properly included or not by loglevel, this could be easily handled the same way.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to