Issue #17487 has been updated by Jeff McCune.
Alex Harvey wrote: > Actually I see the proposal for writing the tests was given at > https://github.com/puppetlabs/facter/pull/357#issuecomment-10530543 Yeah, I should have mentioned that here. The joys of two commentary systems. =) > I can take care of this - I didn't initially think a change of this nature > would pass the cost/benefit test given what I see as a pre-existing need for > far more significant refactoring but I'm happy to do it if required. Sweet, thanks for taking a look at getting the tests in. Unfortunately tests are a requirement, even for really small stuff. They're important because they're the only tool we have to check that your expectations are being met on platforms like HP-UX that we don't have access to. Regarding the cost/benefit analysis... Yes, I totally understand your thinking, but this is a really good example of a situation where I think being disciplined is important. I'm really tempted to say, "Yeah, we're going to refactor that section of code eventually, tests are just overhead and I have code to fix this now, so I'll just merge it." However, I've been around here long enough to know that the best intentions often fall by the wayside, the refactor might not happen for a year or so, and the code that we all thought would only be there for a little while is raising an exception after working without complaint for years. I don't mean this to sound glib or cynical or anything, just as an explanation of why the spec tests are a requirement and are extremely important and valuable. Thanks again for working on this Alex, -Jeff ---------------------------------------- Bug #17487: 'no such interface' sometimes printed on HP-UX platforms https://projects.puppetlabs.com/issues/17487#change-77299 Author: Alex Harvey Status: Tests Insufficient Priority: Normal Assignee: Alex Harvey Category: hpux Target version: 1.6.x Keywords: Branch: https://github.com/puppetlabs/facter/pull/357 Affected Facter version: 1.6.14 On HP-UX platforms facter sometimes prints errors - <pre> $ facter ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface ifconfig: no such interface architecture => ia64 ... </pre> This was identified by Hongbo Hu who submitted a patch in #11612. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
