Issue #17710 has been updated by Alex Harvey.
Actually after digesting the code further I think we could be trying to be too
clever in resolving all IP facts - ipaddress, ipaddress6, macaddress, netmask
and mtu - in a pseudo-platform independent manner. I think this is what has
led to sprawling repeated case blocks and all this hard-to-understand 'action
at a distance' (e.g. the REGEX_MAP).
Perhaps there should be a top-level case statement
<pre>
case Facter.value(:kernel)
when 'HP-UX'
# work out ipaddress, ipaddress6, macaddress, netmask and mtu
when 'Solaris'
# work out ipaddress, ipaddress6, macaddress, netmask and mtu
default
# work out ipaddress, ipaddress6, macaddress, netmask and mtu
end
</pre>
----------------------------------------
Refactor #17710: issues with IP facts
https://projects.puppetlabs.com/issues/17710#change-77451
Author: Alex Harvey
Status: Unreviewed
Priority: Normal
Assignee: Jeff McCune
Category:
Target version:
Keywords:
Branch:
Affected Facter version: 1.6.14
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
