Issue #17856 has been updated by Jeff McCune.

Category set to documentation
Status changed from In Topic Branch Pending Review to Merged - Pending Release
Assignee deleted (Nick Fagerlund)
Target version changed from 3.x to 3.0.2
Affected Puppet version changed from 2.7.8 to 2.7.20

Merged into 2.7.x
----

As 0cd02fd after cleaning up whitespace warnings caught with `git diff master 
--check`.

Thanks Nick!

-Jeff
----------------------------------------
Bug #17856: hasrestart defaults to false, but the doc says it defaults to true
https://projects.puppetlabs.com/issues/17856#change-77823

Author: Per Cederqvist
Status: Merged - Pending Release
Priority: Normal
Assignee: 
Category: documentation
Target version: 3.0.2
Affected Puppet version: 2.7.20
Keywords: hasstatus, hasrestart
Branch: https://github.com/puppetlabs/puppet/pull/1304


[The 
documentation](http://docs.puppetlabs.com/references/latest/type.html#service) 
for hasrestart says that it defaults to true. In fact, it seems to default to 
false.

This was introduced by commit:455c9aab which added the words "Defaults to true; 
note that this is a change from earlier versions of Puppet", but didn't change 
the code to really change the default value.

Maybe the default should be changed, but I'm setting the category to 
"documentation". If it is changed, the text should state which version 
introduced the change, as it does for the hasstatus param.

Based on the output of "git tag --contains 455c9aab" this seems to have been 
present since version 2.7.7.  Since I cannot find that version in the dropdown 
menu, I'm setting it to 2.7.8.  I have verified that I need to add "hasrestart 
=> true" in version 3.0.1.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to