Issue #17447 has been updated by Matthaus Owens. Status changed from Merged - Pending Release to Closed
Released in Puppet 3.0.2-rc1 ---------------------------------------- Bug #17447: Puppet sysv init script faulty https://projects.puppetlabs.com/issues/17447#change-78109 Author: Virgil M Status: Closed Priority: Normal Assignee: Matthaus Owens Category: Target version: 3.0.2 Affected Puppet version: Keywords: Branch: Puppet agent can sometimes fail to restart: <pre> service puppet restart * Restarting puppet agent [ OK ] service puppet restart * Restarting puppet agent [fail] service puppet restart * Restarting puppet agent [ OK ] service puppet restart * Restarting puppet agent [fail] </pre> The reason for this is that 'service puppet stop' does not actually ensure puppet is stopped, and 1 sec is not enough to stop it completely in some cases, so start fails: <pre> [...] restart|force-reload) log_begin_msg "Restarting $DESC" stop_puppet_agent sleep 1 start_puppet_agent </pre> The init script is badly written (--stop does **not** wait for the process to stop), stop should be doing something on the lines of: <pre> start-stop-daemon --stop --retry TERM/10 --quiet --oknodo --pidfile $PIDFILE </pre> The above sleep 1 can then be removed. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
