Issue #15837 has been updated by Jeff McCune. Status changed from Needs More Information to Tests Insufficient Priority changed from High to Normal
> Also, I don’t really know how to write a test for puppet at all; and would be > very thankful if someone could assist. Hopefully the text above is enough to > cover all possible use cases of Linux mount. I recommend looking at the existing spec tests. Please also keep in mind that there is a module named `mount_providers` that splits apart the behaviors implemented in the core mount type into two distinct resources; the `mounttab` and `mountpoint` resources. It might be easier to write tests against these new resource types because the concerns are a bit more cleanly separated out. Do you think this patch is better suited for the [mount_providers](https://github.com/puppetlabs/puppetlabs-mount_providers/) module? In any event, the examples at <https://github.com/puppetlabs/puppetlabs-mount_providers/tree/master/spec/unit/provider/mountpoint> provide a good, up-to-date example of how to write tests for a platform specific provider such as `mount`. I recommend using these RSpec tests as a starting point. Hope this helps, -Jeff ---------------------------------------- Bug #15837: [PATCH] Fix mount with options specified on Linux https://projects.puppetlabs.com/issues/15837#change-78682 Author: Lubomir Rintel Status: Tests Insufficient Priority: Normal Assignee: Category: mount Target version: Affected Puppet version: 2.7.18 Keywords: Branch: https://github.com/puppetlabs/puppet/pull/1021 A hack around mount misbehavior on Mac OS X caused certain options to be set redundantly, which is forbidden for some options on Linux; such as "rootcontext". -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
