Issue #15306 has been updated by Jeff McCune.

Status changed from In Topic Branch Pending Review to Merged - Pending Release
Target version set to 1.6.18

Merged into 1.6.x as bf19fb3.

This should be released in 1.6.18.

Thanks again for the contribution!

-Jeff
----------------------------------------
Bug #15306: 'virtual' fact missing on SmartOS / Solaris
https://projects.puppetlabs.com/issues/15306#change-79428

Author: Jakob Borg
Status: Merged - Pending Release
Priority: Normal
Assignee: 
Category: 
Target version: 1.6.18
Keywords: 
Branch: https://github.com/puppetlabs/facter/pull/249
Affected Facter version: 1.6.10


On a Joyent SmartMachine, facter doens't report the 'virtual' fact. When 
running facter, the warning "Could not retrieve virtual: invalid byte sequence 
in UTF-8" is displayed before the output. The root cause is that 
/proc/self/status is read and checked for a regexp match as part of the test 
for vserver. However the contents are binary (on this platform) and ruby1.9 
throws the exception above. The solution is to read the file in binary mode; 
I'll send a pull request.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to