Issue #593 has been updated by Jeff McCune.
Felix Frank wrote: > So, err, does that mean 2.7.x is no longer receiving patches? Hey Felix, 2.7.x is receiving patches, but only of the "this fixes a bug that causes a crash" or "this fixes a security vulnerability" variety. Bugs like this should target master please. > I shall go on a limb, rebase to 3.x and apply what i *assume* to be a fix to > Jeff's remarks on the pull request. When you rebase, please rebase against master and not 3.x. We actually don't have a 3.x branch right now, just a 3.0.x and a master branch since we're really close to cutting a 3.1.0 RC from the master branch. Once the pull request is based on master we'll figure out the exact version to merge into and then merge up from there. > In all, I have to admit that I'm a bit underwhelmed by the amount of feedback > given to both this issue and the pull request itself. I'm really sorry about this, please ping me directly if you find yourself blocked waiting on feedback from us. I'm trying to improve our tooling in an effort to reduce the overall lag time between a contribution and feedback on the contribution. Things like Trello and Travis CI are helping us reduce this time, but I think this issue fell through the cracks a bit. -Jeff ---------------------------------------- Bug #593: Puppet's cron type struggles with vixie-cron https://projects.puppetlabs.com/issues/593#change-80632 Author: Peter Abrahamsen Status: In Topic Branch Pending Review Priority: Normal Assignee: Jeff McCune Category: cron Target version: Affected Puppet version: 0.25.1 Keywords: cronfixit Branch: After making a few changes to my cron job in my manifest, my crontab begins to look like: <pre> # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Thu Apr 12 12:16:01 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # HEADER This file was autogenerated at Thu Apr 12 12:16:01 -0700 2007 by puppet. # HEADER While it can still be managed manually, it is definitely notrecommended. # HEADER Note particularly that the comments starting with 'Puppet Name' should # HEADER not be deleted, as doing so could cause duplicate cron jobs. # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Wed Apr 11 16:42:40 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Tue Apr 10 13:49:45 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Thu Apr 5 17:36:42 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (/tmp/crontab.XXXXWxMPKB installed on Thu Apr 5 17:08:07 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # Puppet Name: websync */10 * * * * <snip> </pre> If puppet would put its notice just before the first job it manages, I think it would avoid this problem. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to puppet-bugs@googlegroups.com. To unsubscribe from this group, send email to puppet-bugs+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
