Issue #593 has been updated by Jeff McCune. Status changed from In Topic Branch Pending Review to Tests Insufficient Assignee deleted (Jeff McCune)
I commented on the pull request, but doing so here as well: This looks OK, I just need to figure out how to get some test coverage added before we merge this in. Before we merge this, please also make sure the change in behavior regarding the parsed file "API" is documented. That is, parse file providers may implement the native_header_regex and drop_native_header methods. Felix, would you like to take a stab at adding test coverage and YARD documentation to the parsed file base class and to the crontab provider? I'm happy to help out if you need some help. I think the best place to get started with the behavior tests are in spec/unit/provider/parsedfile_spec.rb, spec/shared_behaviours/all_parsedfile_providers.rb, and spec/unit/provider/cron/crontab_spec.rb. Next actions are to add API documentation and behavior examples, we can't merge this without those things in place. ---------------------------------------- Bug #593: Puppet's cron type struggles with vixie-cron https://projects.puppetlabs.com/issues/593#change-80667 Author: Peter Abrahamsen Status: Tests Insufficient Priority: Normal Assignee: Category: cron Target version: Affected Puppet version: 0.25.1 Keywords: cronfixit Branch: After making a few changes to my cron job in my manifest, my crontab begins to look like: <pre> # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Thu Apr 12 12:16:01 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # HEADER This file was autogenerated at Thu Apr 12 12:16:01 -0700 2007 by puppet. # HEADER While it can still be managed manually, it is definitely notrecommended. # HEADER Note particularly that the comments starting with 'Puppet Name' should # HEADER not be deleted, as doing so could cause duplicate cron jobs. # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Wed Apr 11 16:42:40 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Tue Apr 10 13:49:45 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (- installed on Thu Apr 5 17:36:42 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # DO NOT EDIT THIS FILE - edit the master and reinstall. # (/tmp/crontab.XXXXWxMPKB installed on Thu Apr 5 17:08:07 2007) # (Cron version V5.0 -- $Id: crontab.c,v 1.12 2004/01/23 18:56:42 vixie Exp $) # Puppet Name: websync */10 * * * * <snip> </pre> If puppet would put its notice just before the first job it manages, I think it would avoid this problem. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
