Issue #1346 has been updated by Jeff McCune.

Status changed from In Topic Branch Pending Review to Code Insufficient
Assignee deleted (Andrew Parker)
Target version set to 2.x

Michael Moll wrote:
> What's the status of the pull request? I would need a fix for Bug #4498 
> (ipaddress* facts do not include secondary IPs)...

I commented at <https://github.com/puppetlabs/facter/pull/267>, but I'll merge 
this in once it's rebased against master.  It looks like all of the concerns 
have been addressed.  Please make sure to mention my name in the pull request 
so I get a notification that it's ready, otherwise I might overlook the newly 
rebased pull request.

Thanks for the ping,
-Jeff
----------------------------------------
Bug #1346: Using 'ip addr' over ifconfig
https://projects.puppetlabs.com/issues/1346#change-80977

Author: Ian Christian
Status: Code Insufficient
Priority: Normal
Assignee: 
Category: library
Target version: 2.x
Keywords: 
Branch: 
Affected Facter version: 


<pre>
# facter
/usr/lib/ruby/site_ruby/1.8/facter/ipmess.rb:85: command not found: 
/sbin/ifconfig -a
/usr/bin/facter:54: command not found: /sbin/ifconfig -a
/usr/bin/facter:54: command not found: dnsdomainname
/usr/bin/facter:54: command not found: domainname
/usr/bin/facter:54: command not found: /sbin/ifconfig
architecture => i386
domain => internal.HIDDEN
facterversion => 1.3.8
fqdn => ruby-test.internal.HIDDEN
hardwareisa => unknown
hardwaremodel => i686
hostname => ruby-test
id => root
ipaddress => 10.200.201.73
</pre>

It would be nice if when ifconfig can't be found, it falls back to using 'ip 
addr' (or the other way around) - also, notice that domainname and 
dnsdomainname are not present on this system - however facter does appear to 
get them correct regardless.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to