Issue #16635 has been updated by eric sorenson. Status changed from In Topic Branch Pending Review to Tests Insufficient Assignee changed from eric sorenson to Clay Caviness
Clay I put the ticket back to you and marked it 'tests insufficient' ; if you can advance the code by adding some tests that would be awesome; otherwise it'll have to wait on puppetlabs developer time. I'm going to include Jeff Mccune's standard "needs tests" blurb below: Code - missing examples Examples exercising these behavior changes need to be included in the change set before we merge this contribution in. If you're not comfortable adding RSpec examples, I'm happy to help out. I'm jmccune in #puppet-dev on freenode. Please include examples that will automatically let us know if this problem resurfaces in the future, otherwise we may have a regression as we continue to make changes over time. ---------------------------------------- Bug #16635: pkgdmg provider doesn't honor http_proxy_host/http_proxy_port https://projects.puppetlabs.com/issues/16635#change-81273 Author: Clay Caviness Status: Tests Insufficient Priority: Normal Assignee: Clay Caviness Category: OSX Target version: 3.x Affected Puppet version: Keywords: Branch: https://github.com/ahpook/puppet/tree/16635-pkgdmg-proxy The pkgdmg provider doesn't honor http_proxy_host/http_proxy_port settings. The actual file is downloaded using an exec to curl, no proxy information is passed: <pre>curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source</pre> I copied `http_proxy_env`, `http_proxy_host`, and `http_proxy_port` functions from `puppet/forge/repository.rb` and added them to `pkgdmg.rb`, and tweaked the call to curl in `pkgdmg.rb`: <pre>if http_proxy_host and not http_proxy_port curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source, "--proxy", http_proxy_host elsif http_proxy_host and http_proxy_port curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source, "--proxy", "#{http_proxy_host}:#{http_proxy_port}" else curl "-o", cached_source, "-C", "-", "-k", "-L", "-s", "--url", source end </pre> I attached my patched pkgdmg.rb. I don't really understand how the `commands :curl => "/usr/bin/curl"` and `curl 'foo', 'bar', 'baz'` stuff actually works, so there's probably a much smoother way to do this... -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
