Issue #18756 has been updated by Jeff McCune.

Category set to interface
Status changed from Unreviewed to Merged - Pending Release
Target version set to 2.0.0
Branch set to https://github.com/puppetlabs/facter/pull/390

Merged into master as 00925c6.

This should be released in Facter 2.

Thanks again for the contribution!

-Jeff
----------------------------------------
Bug #18756: wront regex in util/ip.rb
https://projects.puppetlabs.com/issues/18756#change-82511

Author: javier wilson
Status: Merged - Pending Release
Priority: Normal
Assignee: 
Category: interface
Target version: 2.0.0
Keywords: 
Branch: https://github.com/puppetlabs/facter/pull/390
Affected Facter version: 1.6.17


if you compare 
https://github.com/puppetlabs/facter/blob/master/lib/facter/ipaddress.rb#L32
      regexp = /inet (?:addr:)?([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+)/
to https://github.com/puppetlabs/facter/blob/master/lib/facter/util/ip.rb#L8
      :ipaddress => /inet addr:([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+)/,

you can see why the second one will not work in Fedora 16+ where the "addr:" 
string no longer exists.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to