Issue #19147 has been updated by Josh Endries.
Yeah, that's exactly my point. :) So in your view "testing your manifests" and "applying your manifests" are the same? It sounds like it's more just a shortcut to run the agent than run a test, like a --single or something. If it's not going to be fixed that's fine, I just find it misleading, and my coworker messed up a system thinking it would just do a test run... On Feb 8, 2013 12:25 PM, <[email protected]> wrote: > Issue #19147 has been updated by Josh Cooper. > > - Status changed from Unreviewed to Rejected > > Hi Josh, the option --test is really about testing your manifests — make > a change, run puppet, see if the expected thing happens, and iterating on > that. I agree that it almost sounds like --noop, but our docs > http://docs.puppetlabs.com/man/agent.html are pretty clear on what these > options do: > > > --noop > Use 'noop' mode where the daemon runs in a no-op or dry-run mode. This is > useful for seeing what changes Puppet will make without actually executing > the changes. > > > --test > Enable the most common options used for testing. These are 'onetime', > 'verbose', 'ignorecache', 'no-daemonize', 'no-usecacheonfailure', > 'detailed-exit-codes', 'no-splay', and 'show_diff'. > > ------------------------------ > Bug #19147: puppet agent --test actually applies > changes<https://projects.puppetlabs.com/issues/19147#change-82841> > > - Author: Josh Endries > - Status: Rejected > - Priority: Normal > - Assignee: > - Category: > - Target version: > - Affected Puppet version: 2.7.19 > - Keywords: > - Branch: > > Hello, > > When I run ‘puppet agent —test’, it actually makes the changes, it doesn’t > just test doing them… I was expecting it to essentially work like —noop. I > think —noop should be included in the options that —test enables (according > to the man page). Or, the man page should explicitly state that it will > apply any changes it finds. I normally view a “test” as something that > doesn’t “actually do” anything, it just looks to see if what it would > normally do will work or not. At this point, I’m not really sure what —test > is for, actually… I searched and looked through 2.7 changelogs but didn’t > see anything that looked like it addressed this. > > $ sudo puppet agent --test > info: Retrieving plugin > info: Loading facts in /etc/puppet/modules/concat/lib/facter/concat_basedir.rb > info: Loading facts in /etc/puppet/modules/cc/lib/facter/cc_os_tag.rb > info: Loading facts in /var/lib/puppet/lib/facter/cc_os_tag.rb > info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb > info: Caching catalog for puppet01 > info: Applying configuration version '1360331524' > notice: /Stage[main]/Puppet::Server/Cron[puppet-monitor]/environment: > environment changed 'MAILTO=...' to 'MAILTO=...' > notice: Finished catalog run in 1.70 seconds > > ------------------------------ > > You have received this notification because you have either subscribed to > it, or are involved in it. To change your notification preferences, please > click here: http://projects.puppetlabs.com/my/account > ---------------------------------------- Bug #19147: puppet agent --test actually applies changes https://projects.puppetlabs.com/issues/19147#change-82952 Author: Josh Endries Status: Rejected Priority: Normal Assignee: Category: Target version: Affected Puppet version: 2.7.19 Keywords: Branch: Hello, When I run 'puppet agent --test', it actually makes the changes, it doesn't just test doing them... I was expecting it to essentially work like --noop. I think --noop should be included in the options that --test enables (according to the man page). Or, the man page should explicitly state that it will apply any changes it finds. I normally view a "test" as something that doesn't "actually do" anything, it just looks to see if what it would normally do will work or not. At this point, I'm not really sure what --test is for, actually... I searched and looked through 2.7 changelogs but didn't see anything that looked like it addressed this. $ sudo puppet agent --test info: Retrieving plugin info: Loading facts in /etc/puppet/modules/concat/lib/facter/concat_basedir.rb info: Loading facts in /etc/puppet/modules/cc/lib/facter/cc_os_tag.rb info: Loading facts in /var/lib/puppet/lib/facter/cc_os_tag.rb info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb info: Caching catalog for puppet01 info: Applying configuration version '1360331524' notice: /Stage[main]/Puppet::Server/Cron[puppet-monitor]/environment: environment changed 'MAILTO=...' to 'MAILTO=...' notice: Finished catalog run in 1.70 seconds -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
