Issue #19153 has been updated by R.I. Pienaar.

Charlie, the problem here is that mcollective does basically "puppet agent 
--daemonize --onetime" which will create all the various locks and pids like 
the daemon started by the rc system.  So when you then do service{"puppet": 
ensure => stopped} that will stop the daemon that mcollective started instead 
of only daemons started by the init script

You can easily reproduce this:

<pre>
# service puppet status ;puppet agent --onetime --daemonize;service puppet 
status; sleep 1; service puppet stop
puppet is stopped
puppet (pid  14892) is running...
Stopping puppet agent:                                     [  OK  ]
# tail -n 1 /var/log/messages
Mar  1 21:32:06 localhost puppet-agent[14892]: Caught TERM; calling stop
</pre>

So the problem is the rc script does not distinguish between a daemon started 
manually and one started by the rc system.
----------------------------------------
Bug #19153: service puppet ensure stopped kills off cron-run puppet with 
"Caught TERM; calling stop"
https://projects.puppetlabs.com/issues/19153#change-84482

Author: Jo Rhett
Status: Needs More Information
Priority: Urgent
Assignee: Jo Rhett
Category: agent
Target version: 3.1.1
Affected Puppet version: 3.1.0
Keywords: 
Branch: 


We have recently switched from puppet agent in daemon mode (for kick) to 
cron-run puppet with mcollective agent. However, I started noticing that puppet 
policies were being inconsistently applied across the hosts. It turns out that 
this policy is the problem:

<pre>
service { 'puppet':
        ensure      => stopped,
        enable      => false,
        require     => File['/etc/cron.d/puppet','/etc/puppet/puppet.conf'],
}
</pre>

I have checked and confirmed that the puppet init script returns the correct 
response even when puppet is running. If I run "puppet agent --test" in one 
window and while it is running I run this in the other window, it shows clear:

<pre>
root@sj2-noc01 ~$ service puppet status ; echo $?
puppet is stopped
3
</pre>

However, if I run puppet in a silent mode with --onetime and --no-daemon then 
the init script returns this value

<pre>
root@sj2-noc01 ~$ service puppet status ; echo $?
puppet (pid  30406) is running...
0
</pre>

This causes it to kill itself off, and not finish the run. Due to the 
semi-random nature of ordering, this happens near the end or near the beginning 
of the puppet run on different hosts. (there are few dependancies on the puppet 
module, so its order in the manifest is random from host to host)

This is clearly a major flaw. We need the above policy to ensure that no puppet 
daemons are running, however it interferes with the cron-run instance. However 
it is handled properly when run verbosely with test.

Environment is a mixture of CentOS 5 & 6.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to