Issue #17710 has been updated by Jeff McCune. Status changed from Merged - Pending Release to Code Insufficient Target version deleted (2.0.0)
@razic Unfortunately we had to revert this change set in master. Could you open up a new pull request once these issues are addressed: First, on Darwin and Linux we're seeing the following error running facter: <pre> $ facter Could not retrieve network_gif0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_en1: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_vboxnet0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_stf0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_fw0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_vmnet1: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_lo0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_en0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_p2p0: undefined local variable or method `label' for Facter::Util::IP:Module Could not retrieve network_vmnet8: undefined local variable or method `label' for Facter::Util::IP:Module </pre> Second, there are test failures in our CI system. This is likely because we're running rspec-2.9 instead of a later version. Ironically, I'm not sure if we can easily reconfigure the CI systems to use a newer version of rspec, but if you're able to isolate the issue to rspec 2.9 then we'll investigate upgrading or switching to automatic dependency resolution. Here's the failed jenkins job: <https://jenkins.puppetlabs.com/job/Facter%20Master/1159/ruby=ruby-1.9.3,rvm=%23rvm/console> Thanks, -Jeff ---------------------------------------- Refactor #17710: issues with IP facts https://projects.puppetlabs.com/issues/17710#change-87871 * Author: Alex Harvey * Status: Code Insufficient * Priority: Normal * Assignee: * Category: * Target version: * Keywords: * Branch: https://github.com/puppetlabs/facter/pull/406 * Affected Facter version: 1.6.14 ---------------------------------------- -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
