Issue #20236 has been updated by Jeff McCune. Status changed from Accepted to In Topic Branch Pending Review Target version changed from 1.7.x to 1.7.1 Branch changed from https://github.com/jeffmccune/facter/tree/fix/1.7.x/20236_lspci_vs_dmidecode to https://github.com/puppetlabs/facter/pull/429
Eric, I think this should be targeted at 1.7.1 since this is a bug fix that affected the 1.6 series and we just released 1.7.0. It's totally cool if we re-assign it to something else, just let me know. The impact data is that an user emailed Daniel and Kenn about this. Daniel pinged me about it this afternoon. -Jeff ---------------------------------------- Bug #20236: Facter does not consult dmidecode if lspci is present https://projects.puppetlabs.com/issues/20236#change-89247 * Author: Jeff McCune * Status: In Topic Branch Pending Review * Priority: Normal * Assignee: * Category: virtual * Target version: 1.7.1 * Keywords: * Branch: https://github.com/puppetlabs/facter/pull/429 * Affected Facter version: 1.6.18 ---------------------------------------- ### Overview When Facter executes lspci and is unable to determine the virtual platform from the output, dmidecode is never consulted. This is a problem because there are situations where the information sufficient to determine the virtual platform is contained in the output of dmidecode, but not the output of lspci. ### Expected Behavior `dmidecode` is consulted when trying to determine the virtual platform, regardless of if lspci is present or not. ### Actual Behavior When `lspci` is present, `dmidecode` is never executed. Steps to reproduce: Stub out `lspci` such that it returns unrelated information and stub out `dmidecode` such that it returns relevant and useful information. Observe that `dmidecode` is never consulted. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
