Issue #12723 has been updated by Matthaus Owens. Status changed from Merged - Pending Release to Closed
Released in Facter 1.7.0 ---------------------------------------- Bug #12723: Puppet apply freezes occasionally https://projects.puppetlabs.com/issues/12723#change-89607 * Author: Timur Batyrshin * Status: Closed * Priority: Normal * Assignee: * Category: library * Target version: 1.7.0 * Keywords: * Branch: https://github.com/puppetlabs/facter/pull/174 * Affected Facter version: ---------------------------------------- I've stumbled recently on puppet hanging occasionally in Ubuntu 10.04 run on t1.micro x64 EC2 instace. Say, 1 out of 3 complex and long puppet apply runs got frozen with process zombified aside. While hanging it was impossible to terminate puppet through usual Ctrl-C however it honored SIGTERM. Tracing back the freeze have lead to Facter using Thread::exclusive in couple of places. Here is my pull request for the fix: https://github.com/puppetlabs/facter/pull/174 After removing Thread::exclusive section the freezes disappeared. These lines were introduced through a series of commits: https://github.com/puppetlabs/facter/commit/c2aa5086ab55da9c708d962b84a1b85404fc6329 (for processor.rb) https://github.com/puppetlabs/facter/commit/a633aebab4dc4d07119a619c21cad6a719552083 (for memory.rb) I see no reason for running the code here in exclusive threads as it only does simple file read and calculation using local variables and does not address anything outside its own block. The original commits neither do clarify the reason for using exclusive threads here. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
