Issue #17887 has been updated by Dominic Cleal.

Status changed from Code Insufficient to In Topic Branch Pending Review
Branch changed from https://github.com/puppetlabs/puppet/pull/1358 to 
https://github.com/puppetlabs/puppet/pull/1614

----------------------------------------
Bug #17887: Failure during property sync results in "Puppet::Util::Log requires 
a message"
https://projects.puppetlabs.com/issues/17887#change-89901

* Author: Dominic Cleal
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Dominic Cleal
* Category: transactions
* Target version: 3.x
* Affected Puppet version: development
* Keywords: resource harness, transaction
* Branch: https://github.com/puppetlabs/puppet/pull/1614
----------------------------------------
During provider development and testing with rspec+mocha and using a test 
catalog, an expectation failure can cause the following log message:

    Could not evaluate: Puppet::Util::Log requires a message

This occurs if the property sync calls a method that has a mocha expectation 
set, but has reached the max call count or similar.

When testing a catalog from a test, the `Puppet::Transaction::ResourceHarness` 
calls `apply_parameter` for a given parameter, which then calls 
`property.sync`.  If the mocha expectation fails inside this sync, the `rescue` 
block is never called (it isn't an exception) but the `ensure` block is still 
run.  This calls `send_log` on the event, but the message is uninitialised at 
that point so the logging fails with the above error.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to