Issue #19196 has been updated by eric sorenson. Description updated Category set to windows Status changed from Unreviewed to Investigating Assignee set to Josh Cooper Target version set to 3.x
Josh this seems like a legit bug that we could work around with smarts in `install_options`. Can you take a look please? ---------------------------------------- Bug #19196: Automatic quoting of install_options breaks NullSoft installation directory parameter https://projects.puppetlabs.com/issues/19196#change-90775 * Author: Josh Davidson * Status: Investigating * Priority: Normal * Assignee: Josh Cooper * Category: windows * Target version: 3.x * Affected Puppet version: * Keywords: * Branch: ---------------------------------------- >From >http://nsis.sourceforge.net/Which_command_line_parameters_can_be_used_to_configure_installers: <pre> **Options** * /D=C:\Bla or /D=C:\Path with spaces ** Set installation folder ($INSTDIR) ** Must be the last parameter on the command line and must not contain quotes even if the path contains blank spaces. ** Related to: $INSTDIR </pre> From: http://docs.puppetlabs.com/references/latest/type.html <blockquote> **windows** Windows package management. This provider supports either MSI or self-extracting executable installers. This provider requires a source attribute when installing the package. It accepts paths paths to local files, mapped drives, or UNC paths. If the executable requires special arguments to perform a silent install or uninstall, then the appropriate arguments should be specified using the install_options or uninstall_options attributes, respectively. Puppet will automatically quote any option that contains spaces. </blockquote> The problem is NullSoft installer doesn't work right when the /D option contains quotes. Also it is required to be at the end, so you can't get cute and shift it in between two other arguments that blobbed together as a single string. In order to be able to install NullSoft packages to non-default paths with spaces, there needs to be some way to disable the auto quoting. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
