Issue #17871 has been updated by Brian Menges.

Richard Clamp wrote:
> Did you modify it on the nagios server as well?

Ahh, correct Richard, i had to modify it on the puppet client side. I thought 
that the processing was all done server side which is why i made the edit there.

I can verify Richard's PR 1649 works.

    root@nagios-01:~# date && puppet agent -t
    Wed May 15 08:39:29 PDT 2013
    Info: Retrieving plugin
    Info: Loading facts in /var/lib/puppet/lib/facter/iptables_version.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/ip6tables_version.rb
    Info: Loading facts in 
/var/lib/puppet/lib/facter/postgres_default_version.rb
    Info: Loading facts in 
/var/lib/puppet/lib/facter/iptables_persistent_version.rb
    racc/parser.rb:27: warning: already initialized constant 
Racc_Runtime_Version
    racc/parser.rb:28: warning: already initialized constant 
Racc_Runtime_Revision
    racc/parser.rb:30: warning: already initialized constant 
Racc_Runtime_Core_Version_R
    racc/parser.rb:31: warning: already initialized constant 
Racc_Runtime_Core_Revision_R
    racc/parser.rb:35: warning: already initialized constant 
Racc_Runtime_Core_Revision_C
    racc/parser.rb:39: warning: already initialized constant 
Racc_Main_Parsing_Routine
    racc/parser.rb:40: warning: already initialized constant 
Racc_YY_Parse_Method
    racc/parser.rb:41: warning: already initialized constant 
Racc_Runtime_Core_Version
    racc/parser.rb:42: warning: already initialized constant 
Racc_Runtime_Core_Revision
    racc/parser.rb:43: warning: already initialized constant Racc_Runtime_Type
    Info: Caching catalog for nagios-01.poc
    Info: Applying configuration version '1368632262'
    Notice: /Stage[main]/Nagios::Server/Exec[make-nag-cfg-readable]/returns: 
executed successfully
    Notice: Finished catalog run in 0.56 seconds
    root@nagios-01:~# date && puppet agent -t
    Wed May 15 08:39:35 PDT 2013
    Info: Retrieving plugin
    Info: Loading facts in /var/lib/puppet/lib/facter/iptables_version.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
    Info: Loading facts in /var/lib/puppet/lib/facter/ip6tables_version.rb
    Info: Loading facts in 
/var/lib/puppet/lib/facter/postgres_default_version.rb
    Info: Loading facts in 
/var/lib/puppet/lib/facter/iptables_persistent_version.rb
    racc/parser.rb:27: warning: already initialized constant 
Racc_Runtime_Version
    racc/parser.rb:28: warning: already initialized constant 
Racc_Runtime_Revision
    racc/parser.rb:30: warning: already initialized constant 
Racc_Runtime_Core_Version_R
    racc/parser.rb:31: warning: already initialized constant 
Racc_Runtime_Core_Revision_R
    racc/parser.rb:35: warning: already initialized constant 
Racc_Runtime_Core_Revision_C
    racc/parser.rb:39: warning: already initialized constant 
Racc_Main_Parsing_Routine
    racc/parser.rb:40: warning: already initialized constant 
Racc_YY_Parse_Method
    racc/parser.rb:41: warning: already initialized constant 
Racc_Runtime_Core_Version
    racc/parser.rb:42: warning: already initialized constant 
Racc_Runtime_Core_Revision
    racc/parser.rb:43: warning: already initialized constant Racc_Runtime_Type
    Info: Caching catalog for nagios-01.poc
    Info: Applying configuration version '1368632262'
    Notice: /Stage[main]/Nagios::Server/Exec[make-nag-cfg-readable]/returns: 
executed successfully
    Notice: Finished catalog run in 0.54 seconds

My nagios setup was using the nagios_host resources instead of the 
nagios_contact resources

Thanks Richard.

----------------------------------------
Bug #17871: Nagios types creating duplicate entries
https://projects.puppetlabs.com/issues/17871#change-91023

* Author: Chris Mague
* Status: Investigating
* Priority: Normal
* Assignee: 
* Category: nagios
* Target version: 
* Affected Puppet version: 3.0.1
* Keywords: nagios
* Branch: 
----------------------------------------
Actual behavior:

When creating a group of nagios resources ( nagios_contactgroups and 
nagios_commands were the two types I tested ) puppet writes duplicate entries 
in the configuration file.

Expected behavior:

A single entry is created for each resource

Note:  I reverted to 2.7.11 and the issue stopped


Repro steps:

1) crate the manifest below 
2) run "puppet apply contactgroups.pp" more than once



example manifest
<pre>
nagios_contactgroup { 'admins':
  ensure  => present,
  alias   => 'Nagios_Admins',
  members => 'root, mague',
  target  => '/tmp/a.cfg',
}

nagios_contactgroup { 'pd_oncall':
  ensure  => present,
  alias   => 'PagerDuty_Controlled_Oncall_Group',
  members => 'mague',
  target  => '/tmp/a.cfg',
}

nagios_contactgroup { 'icingaadmin':
  ensure  => present,
  alias   => 'Contacts_for_when_Icinga_goes_bad',
  members => 'mague, pagerduty',
  target  => '/tmp/a.cfg',
}

nagios_contactgroup { 'org-contact-oncall':
  ensure  => present,
  alias   => 'org_contact_oncall',
  members => 'mague, pagerduty',
  target  => '/tmp/a.cfg',
}

nagios_contactgroup { 'pd_hbase':
  ensure  => present,
  alias   => 'Contactgroup_Pagerduty_HBase',
  members => 'mague',
  target  => '/tmp/a.cfg',
}
</pre>
================================================================================================
example output

<pre>
[cmague@puppet01:/dev/pts/0 ] /tmp 
$ puppet apply contactgroups.pp 
/dev/mem: Permission denied
racc/parser.rb:27: warning: already initialized constant Racc_Runtime_Version
racc/parser.rb:28: warning: already initialized constant Racc_Runtime_Revision
racc/parser.rb:30: warning: already initialized constant 
Racc_Runtime_Core_Version_R
racc/parser.rb:31: warning: already initialized constant 
Racc_Runtime_Core_Revision_R
racc/parser.rb:35: warning: already initialized constant 
Racc_Runtime_Core_Revision_C
racc/parser.rb:39: warning: already initialized constant 
Racc_Main_Parsing_Routine
racc/parser.rb:40: warning: already initialized constant Racc_YY_Parse_Method
racc/parser.rb:41: warning: already initialized constant 
Racc_Runtime_Core_Version
racc/parser.rb:42: warning: already initialized constant 
Racc_Runtime_Core_Revision
racc/parser.rb:43: warning: already initialized constant Racc_Runtime_Type
/dev/mem: Permission denied
/Stage[main]//Nagios_contactgroup[org-contact-oncall]/ensure: created
/Stage[main]//Nagios_contactgroup[admins]/ensure: created
/Stage[main]//Nagios_contactgroup[icingaadmin]/ensure: created
/Stage[main]//Nagios_contactgroup[pd_oncall]/ensure: created
/Stage[main]//Nagios_contactgroup[pd_hbase]/ensure: created
Finished catalog run in 0.65 seconds
[cmague@puppet01:/dev/pts/0 ] /tmp 
$ puppet apply contactgroups.pp 
/dev/mem: Permission denied
racc/parser.rb:27: warning: already initialized constant Racc_Runtime_Version
racc/parser.rb:28: warning: already initialized constant Racc_Runtime_Revision
racc/parser.rb:30: warning: already initialized constant 
Racc_Runtime_Core_Version_R
racc/parser.rb:31: warning: already initialized constant 
Racc_Runtime_Core_Revision_R
racc/parser.rb:35: warning: already initialized constant 
Racc_Runtime_Core_Revision_C
racc/parser.rb:39: warning: already initialized constant 
Racc_Main_Parsing_Routine
racc/parser.rb:40: warning: already initialized constant Racc_YY_Parse_Method
racc/parser.rb:41: warning: already initialized constant 
Racc_Runtime_Core_Version
racc/parser.rb:42: warning: already initialized constant 
Racc_Runtime_Core_Revision
racc/parser.rb:43: warning: already initialized constant Racc_Runtime_Type
/dev/mem: Permission denied
/Stage[main]//Nagios_contactgroup[org-contact-oncall]/ensure: created
Finished catalog run in 0.68 seconds
</pre>





-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to