Issue #21023 has been updated by Adrien Thebo.

Status changed from In Topic Branch Pending Review to Merged - Pending Release
Target version set to 3.3.0

Merged into master in 48d0d3c; this should be released in 3.3.0.

----------------------------------------
Bug #21023: puppet node clean can't change run_mode under 3.x
https://projects.puppetlabs.com/issues/21023#change-93145

* Author: Peter Meier
* Status: Merged - Pending Release
* Priority: Normal
* Assignee: Charlie Sharpsteen
* Category: 
* Target version: 3.3.0
* Affected Puppet version: 3.2.1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1707
----------------------------------------
Since moving from 2.7 to 3.x any exported resource that is defined by a define, 
won't get unexported. Only built-in types get unexported.

This is because the method 
[type_is_ensurable](https://github.com/puppetlabs/puppet/blob/master/lib/puppet/face/node/clean.rb#L150)
 does not anymore evaluate to true for defined resources. Especially 
[environment.known_resource_types.find_definition('', 
resource.restype)](https://github.com/puppetlabs/puppet/blob/master/lib/puppet/face/node/clean.rb#L154)
 does not anymore return the defined type if we're looking for it.

How could this be fixed?

->  environment.known_resource_types.find_definition('', resource.restype) 
should return the defined types again.

Unexporting *all* defined resourced that are ensureable is a crucial task to 
get your nodes properly out of your infrastructure when using exported 
resources.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to