Issue #19440 has been updated by Josh Cooper. Status changed from Unreviewed to Accepted
Thanks Patrick. Btw, is this an issue for all rack deployments or just Unicorn? In any case, we probably want to move the SIGINT handling to the CommandLine entry point, so that webrick based puppetmaster still function. ---------------------------------------- Bug #19440: puppet master should not trap SIGINT https://projects.puppetlabs.com/issues/19440#change-93719 * Author: Patrick Hemmer * Status: Accepted * Priority: Normal * Assignee: * Category: * Target version: * Affected Puppet version: 3.1.0 * Keywords: master unicorn * Branch: ---------------------------------------- Puppet master currently traps SIGINT. This causes problems with rack servers, especially unicorn. Unicorn has it's own SIGINT trap and will shut down the worker processes when it receives it. However because puppet master is trapping SIGINT, unicorn doesn't get the signal, the worker processes are abandoned, and then die once they hit a timeout they have in them. Because the workers are also listening for connections, you cannot start unicorn back up until all the workers die (since it can't bind to the socket). The offending code is here: https://github.com/puppetlabs/puppet/blob/b3bcb6dd385a5a9bca88c56b0e454eac9ac33dcc/lib/puppet/application/master.rb#L142 -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
