Issue #16793 has been updated by Christopher Layne.

There appears to be a bug in the codebase that while `ignorecache` is what is 
documented in the configuration reference and parsed by the configuration 
parser, the catalog compilation code is actually looking for `ignore_cache`.

$ rpm -q puppet
puppet-2.7.15-1.el6.noarch

$ egrep -r ignorecache /opt/puppet/lib/ruby/site_ruby/1.8/puppet
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/defaults.rb:    :ignorecache => 
[false,
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/application/agent.rb:  'verbose', 
'ignorecache', 'no-daemonize', 'no-usecacheonfailure',
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/application/agent.rb:    
Puppet.settings.handlearg("--ignorecache")

$ egrep -r ignore_cache /opt/puppet/lib/ruby/site_ruby/1.8/puppet               
           
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/indirector/indirection.rb:    return 
nil unless cache? and ! request.ignore_cache? and cached = cache.find(request)
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/indirector/request.rb:  attr_accessor 
:key, :method, :options, :instance, :node, :ip, :authenticated, :ignore_cache, 
:ignore_terminus
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/indirector/request.rb:  
OPTION_ATTRIBUTES = [:ip, :node, :authenticated, :ignore_terminus, 
:ignore_cache, :instance, :environment]
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/indirector/request.rb:  def 
ignore_cache?
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/indirector/request.rb:    ignore_cache
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/configurer.rb:      result = 
Puppet::Resource::Catalog.indirection.find(Puppet[:node_name_value], 
fact_options.merge(:ignore_cache => true))

----------------------------------------
Bug #16793: Dead settings are getting silly. Let's kill them all!
https://projects.puppetlabs.com/issues/16793#change-94226

* Author: Nick Fagerlund
* Status: Needs Decision
* Priority: Normal
* Assignee: eric sorenson
* Category: 
* Target version: 3.x
* Affected Puppet version: 3.0.0
* Keywords: 
* Branch: 
----------------------------------------
I've found at least six dead settings on `master` today, and have already 
handled two this week in individual issues. Time for a mass cleanup. Today's 
haul so far:

- `certdnsnames` -- dead for about a year now. 
- `ca_md` -- not referenced anywhere in code. 
- `catalog_format` -- deprecated since at least 2009.
- `dynamicfacts` -- not referenced anywhere in code. 
- `localconfig` -- not referenced anywhere in code. 

There was also `authconfig` and `ldapnodes` (already dealt with in other 
issues), and I'm getting a real hinky feeling from `ignorecache`, since I can 
see two places in the codebase that SET it, but nowhere that READS it. Haven't 
tested behavior on that one yet.

I was working alphabetically on the full list of settings and got through "L". 
I suspect there are more to be found. I'm handing this off because the rest of 
the searching should probably be done by someone who's faster at it than me. My 
approach so far has been:

* Ack for `"Puppet(\.settings)?\[:setting_name\]"`
* If that turns up nothing, ack for `setting_name` alone.
* If that looks sketchy, check defaults.rb and make sure there's not a `:hook 
=>` for the setting with meaningful side effects.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to