[Facter - Bug #21530] cfpropertylist .to_plist method doesn't output Apple standard XML format

[tickets]

Issue #21530 has been updated by Clay Caviness.

Assignee changed from Clay Caviness to Brian Cain

You're not recreating the same thing. This issue is specific to the new 
facter/util/cfpropertylist module and the .to_plist method it has, which in 
many cases overrides the .to_plist method in facter/util/plist

The code snippet to try is
`ruby -r facter -r facter/util/cfpropertylist -e "p = {'foo'=>'bar', 
'baz'=>[1,2,3]}.to_plist({:plist_format=>2}); puts p"`

NB we're explicitly only requiring the cfpropertylist module. The XML output 
from that module's .to_plist method is not standard (valid, yes, but not 
standard).

----------------------------------------
Bug #21530: cfpropertylist .to_plist method doesn't output Apple standard XML 
format
https://projects.puppetlabs.com/issues/21530#change-94715

* Author: Clay Caviness
* Status: Needs More Information
* Priority: Normal
* Assignee: Brian Cain
* Category: 
* Target version: 
* Keywords: 
* Branch: 
* Affected Facter version: 
----------------------------------------
The output when using FORMAT_XML isn't in Apple style, with tab indention, but 
is instead all on one line. While this is valid XML, it's not pretty. We 
generally like to write XML plists and not binary, as they're simpler to read 
without extra tools.

<pre>
$ ruby -r facter -r facter/util/plist -e "p = {'foo'=&gt;'bar', 
'baz'=&gt;[1,2,3]}.to_plist(); puts p"
&lt;?xml version="1.0" encoding="UTF-8"?&gt;
&lt;!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" 
"http://www.apple.com/DTDs/PropertyList-1.0.dtd"&gt;
&lt;plist version="1.0"&gt;
&lt;dict&gt;
  &lt;key&gt;baz&lt;/key&gt;
  &lt;array&gt;
    &lt;integer&gt;1&lt;/integer&gt;
    &lt;integer&gt;2&lt;/integer&gt;
    &lt;integer&gt;3&lt;/integer&gt;
  &lt;/array&gt;
  &lt;key&gt;foo&lt;/key&gt;
  &lt;string&gt;bar&lt;/string&gt;
&lt;/dict&gt;
&lt;/plist&gt;
$ facter --version
1.6.2
$ sudo pkgutil --forget com.reductivelabs.facter
Forgot package 'com.reductivelabs.facter' on '/'.
$ sudo installer -target / -pkg /Volumes/facter-1.7.1/facter-1.7.1.pkg
installer: Package name is facter-1.7.1
installer: Installing at base path /
installer: The install was successful.
$ ruby -r facter -r facter/util/cfpropertylist -e "p = {'foo'=&gt;'bar', 
'baz'=&gt;[1,2,3]}.to_plist({:plist_format=&gt;2}); puts p"
&lt;?xml version="1.0" encoding="UTF-8"?&gt;
&lt;!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" 
"http://www.apple.com/DTDs/PropertyList-1.0.dtd"&gt;
&lt;plist 
version="1.0"&gt;&lt;dict&gt;&lt;key&gt;baz&lt;/key&gt;&lt;array&gt;&lt;integer&gt;1&lt;/integer&gt;&lt;integer&gt;2&lt;/integer&gt;&lt;integer&gt;3&lt;/integer&gt;&lt;/array&gt;&lt;key&gt;foo&lt;/key&gt;&lt;string&gt;bar&lt;/string&gt;&lt;/dict&gt;&lt;/plist&gt;
$ facter --version
1.7.1
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.