Issue #21975 has been updated by Andrew Parker. Assignee changed from Andrew Parker to eric sorenson
I think the appropriate way of dealing with this is to remove the monkey patch. Monkey patching is turning out to be dangerous for a system like puppet where arbitrary other code is plugged into it and has expectations about the underlying runtime. By monkey patching to get around platform differences puppet removes those very differences that other libraries came to expect. This seems to mainly affect reflection used during serialization. We should be able to fix this by removing the reflection in many cases and changing to explicit, static code (has the nice effect of also making the code document the formats better). Where we can't get rid of reflection, then we should create a helper method that can deal with the difference for us. Eric, I don't think we'll be able to get this in 3.3.0, but I think that this bug should be addressed soon (3.3.1?). We want to claim good support for things like F5 and this is causing that support to not work :( ---------------------------------------- Bug #21975: Puppet Monkey patch 'def instance_variables' clashing with SOAP Class... https://projects.puppetlabs.com/issues/21975#change-95720 * Author: Gavin Williams * Status: Needs Decision * Priority: High * Assignee: eric sorenson * Category: * Target version: * Affected Puppet version: 3.0.0 * Keywords: Network device, F5, instance_variables, monkey_patch * Branch: ---------------------------------------- As discussed on Puppet-dev (<https://groups.google.com/forum/#!topic/puppet-dev/bU0_X_MOiuo>) and Puppet-users (<https://groups.google.com/forum/#!searchin/puppet-users/F5/puppet-users/_0d3_yj5xtY/7Kc3K-47RYsJ>), a monkey patch applied to Puppet in [1f4e44c26](https://github.com/puppetlabs/puppet/commit/1f4e44c26) is breaking Puppet's ability to use the SOAP ruby class. Specific issue is in lib/puppet/util/monkey_patches.rb#L188-L194. Andy Parker has suggested that it should be possible for this code to be removed, however need to ensure that there are no unexpected adverse results... However until that happens, any module wanting to use SOAP, such as the Puppetlabs-F5 module, will not work beyond v3.0. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
