Issue #15456 has been updated by Matthias Pigulla.

Does this need help, feedback or otherwise support?

Also note that in #8314 the variant information was intentionally ignored, hope 
these two requirements don't conflict.

----------------------------------------
Bug #15456: Allow macports provider to specific variants
https://projects.puppetlabs.com/issues/15456#change-96063

* Author: John Wiegley
* Status: Accepted
* Priority: Normal
* Assignee: John Wiegley
* Category: package
* Target version: 
* Affected Puppet version: 2.7.17
* Keywords: macports variants
* Branch: 
----------------------------------------
In macports.rb, you'll see this line:

      output = port("-q", :install, @resource[:name], "@#{should}")

If changed to this:

      output = port("-q", :install, @resource[:name], "#{should}")

Then you can freely specify variants as well as versions:

    package { foo:
        ensure => "@1.0.0";
    }

    package { foo:
        ensure => "+bar";
    }

    package { foo:
        ensure => "@1.0.0+bar";
    }

We could support specifying only a version by changing that line to this:

      if should =~ /^[^@+]+$/ then should = "@" + should end
      output = port("-q", :install, @resource[:name], "#{should}")

This retains backwards compatibility, but allows allow of the MacPorts syntax.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to