Issue #22129 has been updated by Dustin Mitchell.

      elsif checksum?(value)
        # XXX This is potentially dangerous because it means users can't write 
a file whose
        # entire contents are a plain checksum

that's evil

----------------------------------------
Bug #22129: file checksumming assumes UTF-8 on ruby-2.0
https://projects.puppetlabs.com/issues/22129#change-96269

* Author: Dustin Mitchell
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 
----------------------------------------
This is another problem blocking successful use of puppet on OS X.  In our 
case, we're editing /etc/kcpasswd, which is a binary file.  The reproduction is

    # echo $'\xa1' > /tmp/x
    # cat foo.pp 
    file { "/tmp/y":
        content => file("/tmp/x"); # contains "\xa1\n"
    }
    # puppet apply foo.pp
    Error: Parameter content failed on File[/tmp/y]: Munging failed for value 
"\xA1\n" in class content: invalid byte sequence in US-ASCII at 
/private/var/root/foo.pp:3

although within my manifests, where the value comes from extlookup, I get

    Error: Failed to apply catalog: Parameter content failed on 
File[/etc/kcpassword]: Munging failed for value "..elided.." in class content: 
invalid byte sequence in UTF-8 at 
/etc/puppet/environments/dmitchell/env/modules/users/manifests/builder/autologin.pp:16

(note the difference in encoding).


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to