Issue #22191 has been updated by Josh Cooper. Status changed from Accepted to In Topic Branch Pending Review Keywords set to windows Branch set to https://github.com/puppetlabs/puppet/pull/1839
This ensures that if we reboot, that any remaining resource in the catalog (and their dependents) will be marked as skipped in the report. This way we don't give the impression that a partial catalog was applied. ---------------------------------------- Bug #22191: When the transaction is cancelled, mark ready resources and their dependents as skipped https://projects.puppetlabs.com/issues/22191#change-96460 * Author: Josh Cooper * Status: In Topic Branch Pending Review * Priority: Normal * Assignee: * Category: * Target version: 3.3.0 * Affected Puppet version: * Keywords: windows * Branch: https://github.com/puppetlabs/puppet/pull/1839 ---------------------------------------- Puppet provides a mechanism for the transaction to be cancelled, meaning that no additional resources (or their dependents) will be evaluated. However, these resources are not included in the report. From a reporting standpoint it's confusing since it appears that only a partial catalog was applied. These resources should be marked as "skipped", so there is no confusion. There is also a bug in transaction.rb: <pre> while (resource = next_resource) && !transaction.stop_processing? </pre> If `stop_processing?` is true, then we've removed a resource from the ready red-black tree, and that resource is lost. The order needs to be switched. Thanks to Patrick for spotting that. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
