Issue #21201 has been updated by Andrew Parker. Status changed from Accepted to In Topic Branch Pending Review Branch set to https://github.com/puppetlabs/puppet/pull/1847
Turns out removing code that tried to make puppet thread safe was much easier than I expected. ---------------------------------------- Refactor #21201: Remove "thread safety" code from puppet https://projects.puppetlabs.com/issues/21201#change-96703 * Author: Andrew Parker * Status: In Topic Branch Pending Review * Priority: Normal * Assignee: eric sorenson * Category: * Target version: 3.x * Affected Puppet version: * Keywords: backlog * Branch: https://github.com/puppetlabs/puppet/pull/1847 ---------------------------------------- The puppet master does not run in threaded environments. Even our use of webrick avoids threads (see <https://github.com/puppetlabs/puppet/blob/3251ebd2a08ab483d5a74f0e8950e4536f477e48/lib/puppet/network/http/webrick.rb#L31-L37>). However, there are large amounts of code and convoluted constructs dedicated to trying (and most likely failing) to make various subsystems in puppet thread-safe. This extra code has multiple down-sides: * False sense of security that you can safely use puppet in a threaded environment * Hard to understand code and high WTF/second count that slows down development * Possible locking overhead at runtime that is not needed I can't think of any upside to keeping these structures around. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
